Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix links to mongodb manual #2232

Merged
merged 1 commit into from
Oct 29, 2020
Merged

Fix links to mongodb manual #2232

merged 1 commit into from
Oct 29, 2020

Conversation

idetox
Copy link
Contributor

@idetox idetox commented Oct 20, 2020 •
edited
Loading

Q A
Type improvement
BC Break no
Fixed issues

Summary

Fixed links to mongodb manual

What does the PR do :

  • Fix links that lead to "page not found"
  • Fix http(s)://docs.mongodb.org to https://docs.mongodb.com
  • Fix some links pointing to /master/ to /manual/ instead

@idetox idetox force-pushed the fix-method-comments-at-see-urls branch from 79cee6e to 792ae11 Compare October 20, 2020 06:32
@malarzm malarzm changed the base branch from master to 2.1.x October 24, 2020 11:59
@malarzm malarzm changed the base branch from 2.1.x to master October 24, 2020 11:59
@malarzm
Copy link
Member

malarzm commented Oct 24, 2020 •
edited
Loading

@idetox thank you for the PR! 2 questions:

  1. could you please rebase your work on top of 2.1.x (and target that branch)? actually nevermind, the links still work so there's no real need to include them in 2.1.x
  2. would you mind fixing other links that point to http://docs.mongodb.org?

@malarzm malarzm added this to the 2.2.0 milestone Oct 24, 2020
@idetox
Copy link
Contributor Author

idetox commented Oct 24, 2020

@idetox thank you for the PR! 2 questions:

  1. could you please rebase your work on top of 2.1.x (and target that branch)? actually nevermind, the links still work so there's no real need to include them in 2.1.x
  2. would you mind fixing other links that point to http://docs.mongodb.org?

Sure i will do it next week!

@idetox idetox force-pushed the fix-method-comments-at-see-urls branch from 792ae11 to 963e0fc Compare October 28, 2020 08:14
@idetox idetox changed the title Fix broken @see urls from Builder methods' comments Fix links to mongodb manual Oct 28, 2020
@idetox
Copy link
Contributor Author

idetox commented Oct 28, 2020

@malarzm done, fixed all links to mongodb manual + updated description

@SenseException
Copy link
Member

The Code Quality break is unrelated to the PR

@malarzm
Copy link
Member

malarzm commented Oct 29, 2020

@idetox awesome, thank you!

@malarzm malarzm merged commit 0bf54d9 into doctrine:master Oct 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SenseException SenseException SenseException approved these changes

Assignees
No one assigned
Labels
Documentation
Projects
None yet
Milestone
2.2.0
Development

Successfully merging this pull request may close these issues.
3 participants
@idetox @malarzm @SenseException