Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Assert array value is an instance of the key #2239

Merged
merged 1 commit into from
Nov 3, 2020
Merged

Assert array value is an instance of the key #2239

merged 1 commit into from
Nov 3, 2020

Conversation

malarzm
Copy link
Member

@malarzm malarzm commented Nov 3, 2020

This PR cherry-picks part of #2234 to make PHPStan happy in 2.1.x branch.

@malarzm malarzm added the Task label Nov 3, 2020
@malarzm malarzm added this to the 2.1.3 milestone Nov 3, 2020
@malarzm
Copy link
Member Author

malarzm commented Nov 3, 2020

I hope the PHPStan's error will go away as we upgrade it.

@malarzm malarzm merged commit 1409465 into 2.1.x Nov 3, 2020
@malarzm malarzm deleted the cherry-pick-2234 branch November 3, 2020 22:16
@franmomu
Copy link
Contributor

franmomu commented Nov 4, 2020

I hope the PHPStan's error will go away as we upgrade it.

Looks like it's because the error formatter, I'll make a PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Task
Projects
None yet
Milestone
2.1.3
Development

Successfully merging this pull request may close these issues.
3 participants
@malarzm @franmomu @greg0ire