support wildcard index mapping #2372
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alcaeus
approved these changes
Sep 30, 2021
|
We could add a mapping test to see if the wildcard index can be correctly mapped in both annotations and XML mappings. Other than that, I'm not sure if we even need to make any logic changes. |
IonBazan
force-pushed
the
bugfix/wildcard-indexes
branch
from
b107eb9
to
e2d231f
Compare
franmomu
approved these changes
Oct 15, 2021
|
|
||
| class WildcardIndexDocument | ||
| { | ||
| protected $id; |
There was a problem hiding this comment.
Suggested change
| protected $id; | |
| private $id; |
There was a problem hiding this comment.
PHPCS is reporting this property as unused when it's private so I will just revert this change. That explains why all other models in this namespace use protected properties too.
IonBazan
force-pushed
the
bugfix/wildcard-indexes
branch
from
4197f3e
to
e2d231f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This enables us to map indexes with
field.$**name.