Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove key template for iterators #2386

Merged
merged 1 commit into from
Nov 15, 2021

Conversation

franmomu
Copy link
Contributor

@franmomu franmomu commented Nov 3, 2021

Q A
Type improvement
BC Break no
Fixed issues

Summary

I think there is no need for specifying the key as template when using iterators, otherwise we (and users) always have to use: Iterator<key, User> instead of Iterator<User>.

I've used mixed as key because of Iterator::key definition. In the tests directory, all the occurrences I've found are using int.

@franmomu franmomu added the Task label Nov 3, 2021
@malarzm malarzm merged commit 9a54beb into doctrine:2.3.x Nov 15, 2021
@malarzm malarzm added this to the 2.3.0 milestone Nov 15, 2021
@malarzm
Copy link
Member

malarzm commented Nov 15, 2021

Thanks @franmomu!

@franmomu franmomu deleted the remove_key_template branch November 16, 2021 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants