Use array_diff_key to get diff for new or deleted documents #2388
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IonBazan
changed the title
|
@pepeh thanks for reporting and solving the problem. Can you add some tests to verify the new behaviour? Please also run |
|
@IonBazan Thank you. I have fixed code style. We already have test cases |
IonBazan
approved these changes
Nov 7, 2021
franmomu
approved these changes
Nov 7, 2021
lib/Doctrine/ODM/MongoDB/PersistentCollection/PersistentCollectionTrait.php
Outdated
Show resolved
Hide resolved
malarzm
approved these changes
Nov 11, 2021
There was a problem hiding this comment.
IIRC the is_object check could come from some ooold times when PersistentCollection was meant to be used with other collection thingies. As it's only used for holding objects I think it's safe to drop it (but I'm still in vacation mode so I might be wrong 👼)
All in all, the change looks good to me 👍
IonBazan
approved these changes
Nov 12, 2021
|
Thank you @pepeh! ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Avoid of array_udiff usage for getDeletedDocuments and getInsertedDocuments functions