Reuse workflows from upstream #2390
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Note that the mongodb extension is no longer installed in the coding standards job, where it is probably not useful.
greg0ire
commented
Nov 13, 2021
| # "GITHUB_TOKEN": ${{ secrets.ORGANIZATION_ADMIN_TOKEN }} | ||
| # "SIGNING_SECRET_KEY": ${{ secrets.SIGNING_SECRET_KEY }} | ||
| # "GIT_AUTHOR_NAME": ${{ secrets.GIT_AUTHOR_NAME }} | ||
| # "GIT_AUTHOR_EMAIL": ${{ secrets.GIT_AUTHOR_EMAIL }} |
There was a problem hiding this comment.
I thought you were the ones uncommenting this step, but turns out you don't…
Source: https://github.com/orgs/doctrine/teams/doctrinecore/discussions/20?from_comment=31#discussion-20-comment-31
franmomu
approved these changes
Nov 17, 2021
SenseException
approved these changes
Nov 17, 2021
|
Sorry I'm late to the party! This is great, 2 less configs to maintain :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note that the mongodb extension is no longer installed in the coding
standards job, where it is probably not useful.
Tthe settings will need to be changed right before merging this, to adapt the name of the coding standard workflow.
Also note that the Static Analysis and Continuous Integrations could not be reuse, among other things because they don't allow configuring extra extensions yet.