Fix deprecation notices Indexes annotation

[jmikola]

Q	A
Type	improvement
BC Break	no
Related issues	#2235, #2249

Summary

The Indexes attribute/annotation was deprecated in doctrine/mongodb-odm@7435e66 for 2.2. There were deprecation messages added for using Indexes at the class level, and indexes within the Document annotation; however, it looks like Indexes on the property level was missed.

Also, one of the deprecation messages got screwed up in doctrine/mongodb-odm@3bdfe97. The message changed but the sprintf args weren't swapped to account for that.

I struggled to add tests for this because:

• trigger_deprecation calls @trigger_error(), so output is silenced. I could theoretically use error_get_last() to check for the deprecation message, but there's no prior art for doing so. In fact, no deprecation messages seem to be tested.
• The Indexes attribute cannot target a property, so the property-level deprecation message could only trigger when using it as annotation.
• I couldn't discern the syntax for using Indexes as a class-level attribute with Index nested within. I consulted Support for nesting attributes with PHP 8.1 orm#9241 some some examples of nesting attributes, but all of my attempts resulted in exceptions (e.g. $value property of Indexes couldn't be set).

For manual testing of the annotation form, this is what I used:

/**
 * @ODM\Document
 * @ODM\Indexes({
 *   @ODM\Index(keys={"foo"="asc"})
 * })
 */
class DeprecatedIndexesAttributeOnClass
{
    /**
     * @ODM\Field(type="string")
     * @ODM\Indexes({
     *   @ODM\Index()
     * })
     */
    public string $foo;
}

[IonBazan]

I think we are missing tests for deprecation messages. Should we add them in this PR then?

[jmikola]

I think we are missing tests for deprecation messages. Should we add them in this PR then?

I'll make an attempt to do so before wrapping this up. We have some prior art for doing this in PHPLIB, but Expecting Deprecations (E_USER_DEPRECATED) may have a better approach.

[jmikola]

I made some progress in asserting deprecation messages, but ran into a roadblock attempting to use Indexes as an attribute (annotation is fine). I'll hold off on this until we can talk it through in the Slack thread.

[jmikola]

Manually rebased on 2.7.x, since that's the same branch I used for previous fixes (#2627).

[jmikola]

Deprecation messages for annotations are now tested. CI failures are unrelated to this PR and due to #2624.

[IonBazan]

I think we can also use https://symfony.com/doc/current/components/phpunit_bridge.html but seems like a drastic change so let's keep it this way for now.

[jmikola]

Aye. We use that on the MongoDB driver but I noted it wasn't being utilized here.