Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PHPStan 1.10.28, Psalm 5.14.1 #10895

Merged
merged 1 commit into from
Aug 9, 2023
Merged

PHPStan 1.10.28, Psalm 5.14.1 #10895

merged 1 commit into from
Aug 9, 2023

Conversation

derrabus
Copy link
Member

@derrabus derrabus commented Aug 9, 2023

No description provided.

@derrabus derrabus added this to the 2.16.1 milestone Aug 9, 2023
@derrabus
Copy link
Member Author

derrabus commented Aug 9, 2023 •
edited
Loading

Apparently, Psalm does not infer the return type of str_replace(string, string, string) as string anymore and wants us to handle possible array return values. I've baselined all errors caused by that issue.

edit: I could fix all of those errors.

@derrabus derrabus requested a review from greg0ire August 9, 2023 10:08
@derrabus derrabus merged commit 597a63a into doctrine:2.16.x Aug 9, 2023
41 checks passed
@derrabus derrabus deleted the bump/sa branch August 9, 2023 13:05
@github-actions github-actions bot mentioned this pull request Aug 9, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@greg0ire greg0ire Awaiting requested review from greg0ire

Assignees
No one assigned
Labels
Static Analysis
Projects
None yet
Milestone
2.16.1
Development

Successfully merging this pull request may close these issues.
1 participant
@derrabus