SchemaValidator: Adapting to new DBAL mapping of bigint

[ThomasLandauer]

Closes #11377

[greg0ire]

Have you tried that on a real project?

[ThomasLandauer]

• With the current BigIntType::class => 'string', I'm getting the mapping error with:

  private ?int $foo = null;

  But not with:

  private string|array|null $foo = null; // i.e. `string` doesn't have to be the only type

• With the new BigIntType::class => 'string|int', I'm still getting it with:

  private ?int $foo = null;

  But not with any of these:

  private string|int|null $foo = null;
  private int|string|null $foo = null; // i.e. order doesn't matter
  private string|int|array|null $foo = null; // i.e. some "bogus" alternative like `array` is still allowed

=> So this does indeed look like a step forward to me.

[greg0ire]

We still support DBAL 3 though… maybe we should keep string when DBAL 3 is installed?

[ThomasLandauer]

Yeah, but how can the version of DBAL be detected here?

[greg0ire]

You could test for the existence of BigIntType::getName() with a call to method_exists(). That method does not exist with DBAL 4.

[ThomasLandauer]

OK, but how can I do this inside this const?

[greg0ire]

I don't think you can, you'd probably have to convert the const to a property.

[derrabus]

No tests. 🤷🏻‍♂️

[ThomasLandauer]

In #11399 I started over (using git CLI ;-) so I'm closing here.