Deprecate the \Doctrine\ORM\Query\Parser::setCustomOutputTreeWalker() method
#11641
+14
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…)` method We use this method only from within one of our own test cases, and I don't see how it would be useful to anybody else outside – it has to be called on the `Parser` instance which exists internally in the `Query` only. Deprecating and removing it in 3.x allows for a slight simplification in the `Parser` there, since we do no longer need the field (it can be a local variable).
mpdude
force-pushed
the
deprecate-set-output-walker
branch
from
fd9aef0
to
f3c1d71
Compare
greg0ire
reviewed
Oct 9, 2024
greg0ire
approved these changes
Oct 9, 2024
|
Thanks @mpdude ! |
derrabus
added a commit
to derrabus/orm
that referenced
this pull request
Oct 9, 2024
* 2.20.x: Remove vendor prefix of PHPDoc referencing class-string (doctrine#11643) Deprecate the `\Doctrine\ORM\Query\Parser::setCustomOutputTreeWalker()` method (doctrine#11641)
derrabus
added a commit
to derrabus/orm
that referenced
this pull request
Oct 9, 2024
* 2.20.x: Remove vendor prefix of PHPDoc referencing class-string (doctrine#11643) Deprecate the `\Doctrine\ORM\Query\Parser::setCustomOutputTreeWalker()` method (doctrine#11641)
derrabus
added a commit
to derrabus/orm
that referenced
this pull request
Oct 9, 2024
* 3.3.x: Remove vendor prefix of PHPDoc referencing class-string (doctrine#11643) Deprecate the `\Doctrine\ORM\Query\Parser::setCustomOutputTreeWalker()` method (doctrine#11641)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We use this method only from within one of our own test cases, and I don't see how it would be useful to anybody else outside – it has to be called on the
Parserinstance which exists internally in theQueryonly.Deprecating and removing it in 4.0 allows for a slight simplification in the
Parserthere, since we do no longer need the field (it can be a local variable).