Run risky code in finally block #11646
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
catch blocks are not supposed to fail. If you want to do something despite an exception happening, you should do it in a finally block. Closes doctrine#7545
|
Should I move the call to |
SenseException
approved these changes
Oct 9, 2024
There was a problem hiding this comment.
Should I move the call to commit() inside the finally block as well? 🤔
I don't know. It looks like it would all be the same in your changes. Logically, from a reading perspective, it would look weird if the commit would be in finally
Does anyone know why $conn->isTransactionActive() wasn't used in the EntityManager in the past?
|
as a transaction was started, it should be active during rollback if not, it exposes userland closed more transactions than it opened |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
catchblocks are not supposed to fail. If you want to do something despite an exception happening, you should do it in afinallyblock.(finally) Fixes #7545