[GH-8327] Make EntityManagerProvider compatible with expected DoctrineBundle usage #8646
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… DoctrineBundle usage.
beberlei
changed the title
simPod
reviewed
Apr 23, 2021
| } | ||
|
|
||
| public function getDefaultConnection(): Connection | ||
| { | ||
| return $this->entityManagerProvider->getManager('default')->getConnection(); | ||
| return $this->entityManagerProvider->getManager($this->defaultManagerName)->getConnection(); |
There was a problem hiding this comment.
I wonder whether this should leverage EntityManagerProvider::getDefaultManager() now when we have it (if $defaultManagerName was not provided).
There was a problem hiding this comment.
Yes you are right, this would be better.
…r in ConnectionFromManagerProvider
simPod
approved these changes
Apr 25, 2021
simPod
added a commit
to simPod/orm
that referenced
this pull request
May 4, 2021
beberlei
pushed a commit
that referenced
this pull request
May 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This complication of the
EntityManagerProviderAPI with a new method is necessary, because during integration in DoctrineBundle doctrine/DoctrineBundle#1327 it showed that theiremoption defaults toNULL, which isn't compatible with ORM usingdefaultas the default value.Related #8327 #8524
Fixes #8643