Remove incorrect (outdated) validation for public fields in SchemaValidator

[da-eto]

Doctrine 2.4 now supports proxy objects for entites with public properties. But SchemaValidator still checks that mapped properties in entities should be private or protected. Can we omit this validation?

[doctrinebot]

Hello,

thank you for creating this pull request. I have automatically opened an issue
on our Jira Bug Tracker for you. See the issue link:

http://www.doctrine-project.org/jira/browse/DDC-2957

We use Jira to track the state of pull requests and the versions they got
included in.

[Ocramius]

@Da-eto-Ya I didn't try it, but I'm not really sure if this still affects HHVM

[da-eto]

Are you mean this: Ocramius/ProxyManager#127 ?

[Ocramius]

@Da-eto-Ya yes, so far I've seen HHVM hang on that hack. I wouldn't remove the notice until we improved that.
The PR can stay open till then

[stof]

maybe we should improve the wording of the message to mention that the issue only affects HHVM now ?

[Ocramius]

I will try a run of HHVM with the latest PHPUnit first

[Ocramius]

Created #936 - let's see what travis says...

[Ocramius]

Went through this and it is actually ok.

[Ocramius]

Note: we still depend on facebook/hhvm#1930 for this