Remove console helper #9640
Merged
Remove console helper #9640
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
derrabus
force-pushed
the
remove/console-helper
branch
from
ed502c2
to
ed7eec3
Compare
SenseException
previously approved these changes
Apr 10, 2022
derrabus
force-pushed
the
remove/console-helper
branch
from
ed7eec3
to
95afc0b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follows #8524.
The original deprecation affected the integration of the
EntityManagerHelperclass only. But if we remove all that, we're left with a trvial class that does not follow current Symfony best practices and is not covered by any tests. This is why I'd like to remove theEntityManagerHelperclass as well. It does not serve any purpose for us anymore and could easily be recreated in userland if applications still rely on such a helper.