Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop support for PHP 7.1 #152

Closed
wants to merge 2 commits into from
Closed

Conversation

franmomu
Copy link
Contributor

@franmomu franmomu commented Dec 19, 2020

I've seen in other doctrine packages that support for 7.1 has been dropped, even 7.2. I don't know the policy for dropping PHP versions.

I think the order in which the call to loadMetadataForClass and isTransient is made does not matter in the test I've changed, but maybe I'm wrong.

TestCase::at method is deprecated in PHPUnit 9. In this case the
order is not important, just that the call is made.
@greg0ire
Copy link
Member

I've seen in other doctrine packages that support for 7.1 has been dropped, even 7.2. I don't know the policy for dropping PHP versions.

True, but also: doctrine/dbal#4386

@franmomu
Copy link
Contributor Author

franmomu commented Jan 2, 2021

I've seen in other doctrine packages that support for 7.1 has been dropped, even 7.2. I don't know the policy for dropping PHP versions.

True, but also: doctrine/dbal#4386

oh, I didn't see that one, perfect.

@franmomu franmomu closed this Jan 2, 2021
@franmomu franmomu deleted the drop_php_71 branch January 2, 2021 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants