Fix Metadata Caching when it changes in EventListeners #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dron-alterpost
force-pushed
the
fix-metadata-caching-1-1-x
branch
from
2e1a160
to
af490ed
Compare
Pavlentiycomua
previously approved these changes
Feb 18, 2019
…data-caching-1-1-x
Ocramius
suggested changes
Feb 21, 2019
|
|
||
| if ($pos === false) { | ||
| return $class; | ||
| switch (true) { |
There was a problem hiding this comment.
Please don't use switch(true). Two if blocks are a better solution here.
lib/Doctrine/Common/Persistence/Mapping/AbstractClassMetadataFactory.php
Outdated
Show resolved
Hide resolved
lib/Doctrine/Common/Persistence/Mapping/AbstractClassMetadataFactory.php
Outdated
Show resolved
Hide resolved
lib/Doctrine/Common/Persistence/Mapping/AbstractClassMetadataFactory.php
Outdated
Show resolved
Hide resolved
Ocramius
suggested changes
Feb 26, 2019
| */ | ||
| private function getRealClass(string $class) : string | ||
| protected function getRealClassName(string $className) : string |
There was a problem hiding this comment.
This should most likely stay private
There was a problem hiding this comment.
This is protected as per suggestion of @alcaeus at #21 (comment)
| { | ||
| $pos = strrpos($class, '\\' . Proxy::MARKER . '\\'); | ||
| if (isset($this->aliasesMap[$className])) { |
There was a problem hiding this comment.
Considering that duplicate entries are allowed, is this property still needed?
There was a problem hiding this comment.
This was done because of #21 (comment) Can you please decipher comment chain and explain if something still needs to be done?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've closed PR #21 and created new one, because that PR is targeted on master.
This PR fixed 2 bugs: