Fix parsing definition list term #154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yes, sorry, edited the message. |
greg0ire
reviewed
Jul 8, 2021
tests/Functional/tests/standalone-email-addresses/standalone-email-addresses.html
Show resolved
Hide resolved
javiereguiluz
approved these changes
Jul 9, 2021
The classifier token should be " : " instead of ":"
greg0ire
approved these changes
Jul 9, 2021
|
Thanks @wouterj ! |
wouterj
added a commit
to wouterj/phpDocumentor
that referenced
this pull request
Apr 9, 2022
The separator is " : ", and not only a colon. See also doctrine/rst-parser#154
jaapio
pushed a commit
to phpDocumentor/guides
that referenced
this pull request
Apr 12, 2022
The separator is " : ", and not only a colon. See also doctrine/rst-parser#154
phpdoc-bot
pushed a commit
to phpDocumentor/guides-restructured-text
that referenced
this pull request
Apr 12, 2022
The separator is " : ", and not only a colon. See also doctrine/rst-parser#154
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is catched by @javiereguiluz and reported in symfony-tools/docs-builder#108 The classifier token should be " : " instead of ":".
Tests are however failing: somehow, a space is lost. Twig renders with the space, but somewhere in the templating logic of this library, we remove the space.. I'm lost on where this happens.I also removed
spaceless. It removes any whitespace between HTML tags, which is not expected for inline HTML tags (it removes any whitespace). In another PR, I'll remove the other usages ofspaceless(in symfony-tools/docs-builder#80 (comment) it was concluded that this never has the intended effect)