Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove nested ifs from DocumentParser #167

Merged
merged 1 commit into from
Oct 21, 2021
Merged

Remove nested ifs from DocumentParser #167

merged 1 commit into from
Oct 21, 2021

Conversation

wouterj
Copy link
Collaborator

@wouterj wouterj commented Oct 20, 2021 •
edited
Loading

Little simplification, see #165 (review) (better reviewed with whitespace disabled)

cc @weaverryan

@greg0ire greg0ire added this to the 0.4.4 milestone Oct 21, 2021
@greg0ire greg0ire merged commit 73992ea into doctrine:0.4.x Oct 21, 2021
@greg0ire
Copy link
Member

Thanks @wouterj !

@wouterj wouterj deleted the documentparser-nested-if-simplification branch October 21, 2021 18:45
@github-actions github-actions bot mentioned this pull request Oct 21, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@greg0ire greg0ire greg0ire approved these changes

Assignees
No one assigned
Labels
Improvement
Projects
None yet
Milestone
0.4.4
Development

Successfully merging this pull request may close these issues.
2 participants
@wouterj @greg0ire