Fix duplicate implicit references with the same id #175
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a common bug in the docs (it has been reported multiple times over the past couple weeks).
If two or more titles on the same page have the same name, the references to the sections is wrong (as the ID is duplicate, you can never link to the second section).
Sphinx/docutils solve this by replacing any duplicate internal references with
id1
,id2
, etc. I suggest making things a bit nicer by adding-1
,-2
, ... to the actual reference ID instead.For reference, docutils actually manages references using a node visitor pattern. We've discussed adding something like this before (#145), but with the ongoing development on PHPdocumentor's side, I'm trying to keep the changes to this library to a minimal.