Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix definition list bug #271

Merged
merged 1 commit into from
Jul 21, 2023
Merged

Fix definition list bug #271

merged 1 commit into from
Jul 21, 2023

Conversation

greg0ire
Copy link
Member

No description provided.

Definition list are composed by a term and a definition block. The term
and the definition block may not be separated by a blank line. Lines
with only whitespace are considered blank.
@greg0ire greg0ire changed the title Failing test case for ORM docs bug Fix definitin list bug Jul 19, 2023
@greg0ire
Copy link
Member Author

@linawolf Hi! For context, before we even consider using guides on doctrine-website, we have to switch that repo to PHP 8. @SenseException is attempting that with doctrine/doctrine-website#476, and is blocked by this issue.

@greg0ire greg0ire changed the title Fix definitin list bug Fix definition list bug Jul 19, 2023
Copy link
Member

@SenseException SenseException left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've tested it on the website build and it solved the problems that are caused by the ORM rst files. 👍

@linawolf
Copy link
Collaborator

Looks good to me

@greg0ire greg0ire merged commit 82f73b0 into doctrine:0.5.x Jul 21, 2023
@greg0ire greg0ire deleted the fix-dl branch July 21, 2023 07:55
@greg0ire greg0ire added this to the 0.5.5 milestone Jul 21, 2023
@greg0ire greg0ire added the Bug Something isn't working label Jul 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants