Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactoring #46

Merged
merged 1 commit into from
Nov 14, 2018
Merged

Refactoring #46

merged 1 commit into from
Nov 14, 2018

Conversation

jwage
Copy link
Member

@jwage jwage commented Nov 7, 2018 •
edited
Loading

fixes #36

  • Reduce usage of inheritance.
  • Separate node rendering from the nodes themselves.
  • Get rid of reliance on __toString() for nodes

@jwage jwage added Improvement WIP Work in progress. labels Nov 7, 2018
@jwage jwage added this to the 0.0.2 milestone Nov 7, 2018
@jwage jwage self-assigned this Nov 7, 2018
@jwage jwage removed the WIP Work in progress. label Nov 12, 2018
@jwage jwage changed the title Start to separate the nodes themselves and the rendering of nodes. Refactoring Nov 14, 2018
@jwage jwage force-pushed the node-renderers branch 5 times, most recently from 59e1dfb to 88354ae Compare November 14, 2018 17:44
@jwage jwage merged commit 028bc37 into master Nov 14, 2018
@jwage jwage deleted the node-renderers branch November 14, 2018 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jwage jwage

Labels
Improvement
Projects
None yet
Milestone
0.0.2
Development

Successfully merging this pull request may close these issues.

Nodes should not render themselves
1 participant
@jwage