Throwing an unknown directive earlier and with more info #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can we update the test to check the additional information about the file and line the unknown directive was found in? |
|
Updated! There's no existing test where the "Environment" actually contains the filename, unfortunately. So, we can add that - it's just a bit more work - not too familiar with the tests - but let me know :) |
jwage
approved these changes
Dec 16, 2018
jwage
approved these changes
Dec 16, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #71 - this solves it in just one case... and it may be that we just need to add this contextual information piece-by-piece.
The if statement was moved because, before, it would find the directive, set it, then only explode LATER. This makes it explode as soon as it finds a directive that it doesn't know about (which allows us to print more contextual information).