Tokenize purely using regexes #123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvorisek
force-pushed
the
tokenize_using_single_regex
branch
4 times, most recently
from
a492556
to
056670d
Compare
mvorisek
force-pushed
the
tokenize_using_single_regex
branch
4 times, most recently
from
3a81fb4
to
1a8dc67
Compare
greg0ire
reviewed
Aug 6, 2024
mvorisek
force-pushed
the
tokenize_using_single_regex
branch
from
1a8dc67
to
9ed8bdb
Compare
greg0ire
reviewed
Sep 10, 2024
+7% speedup
mvorisek
force-pushed
the
tokenize_using_single_regex
branch
from
9ed8bdb
to
808c095
Compare
|
last 3 commits squashed (3rd commit was reverting 1st commit, therefore the resulting/last commit is very simple) |
derrabus
approved these changes
Sep 11, 2024
|
Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Match next token using single regex only, +18% speedup.
In the future,
Tokenizer::makeTokenizeRegexes()method can be made public to allow grammar override for each token type.