fix: Update scope to default to static when memberof #1151
Conversation
| @@ -22933,12 +22934,13 @@ Array [ | |||
| "static": Array [], | |||
| }, | |||
| "name": "getUndefined", | |||
| "namespace": "MyClass.getUndefined", | |||
| "namespace": ".MyClass.getUndefined", | |||
There was a problem hiding this comment.
Looks like this is a regression? Namespaces shouldn't start with ..
There was a problem hiding this comment.
This is a strange case. In the tests MyClass is a member of com.Test. However com.Test is never defined. Should the name space be com.Test.MyClass.getUndefined? or should it remain MyClass.getUndefined?
There was a problem hiding this comment.
This should probably remain as MyClass.getUndefined, and the way we format namespaces should avoid prefixing static scopes with .
There was a problem hiding this comment.
@tmcw there's currently a namespace on master in the test snapshots that starts with a ..
This is the same scenario as above except in this case the static is implied from the syntax tree instead of being assumed based on the @memberof tag.
Adding memo && here would remove the leading . in all cases including cases currently in master. Let me know how I should proceed.
fix: Update scope to default to static when memberof
fix #197