Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify full line annotation markers #4821

Closed
wants to merge 1 commit into from
Closed

Conversation

jorg-vr
Copy link
Contributor

@jorg-vr jorg-vr commented Jul 10, 2023

This pull request creates only a single marker for annotations that span a full line.

In a complex example that reduced the number of rendered marker webcomponents from 948 to 433

  • Tests were added
  • Documentation update can be found at dodona-edu/dodona-edu.github.io#
  • We learned with dolos that using ... isn't a good idea with variable length arrays. This had unexpected performance implications.
  • Don recreate tooltips every time

Closes # .

@jorg-vr jorg-vr added the enhancement A change that isn't substantial enough to be called a feature label Jul 10, 2023
@jorg-vr jorg-vr self-assigned this Jul 10, 2023
@jorg-vr
Copy link
Contributor Author

jorg-vr commented Jul 24, 2023

There is already a more relevant speedup included in #4643
When reviewing #4643 we also decided that we will do the markings on hidden text, making these changes irrelevant

@jorg-vr jorg-vr closed this Jul 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement A change that isn't substantial enough to be called a feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant