Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support evergreen browsers #100

Merged
merged 8 commits into from
Jun 1, 2018
Merged

Support evergreen browsers #100

merged 8 commits into from
Jun 1, 2018

Conversation

matt-gadd
Copy link
Contributor

@matt-gadd matt-gadd commented Jun 1, 2018

Adds a new legacy flag that defaults to true to be backwards compatible. When set to false, uses our esm versions (.mjs) of our deps rather than the down emitted es5 umd (.js) modules.

Has to use a custom ts import transformer (which we should eventually move to webpack-contrib), to give us the same parity on bundling/codesplitting that we got before from a combination of the promise-loader and umd-compat-loader, neither which are used in evergreen.

Apart from the above the changes are mostly cribbed from the cli-build-widget changes here: dojo/cli-build-widget#11

@codecov
Copy link

codecov bot commented Jun 1, 2018

Codecov Report

Merging #100 into master will decrease coverage by 4.63%.
The diff coverage is 16.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #100      +/-   ##
==========================================
- Coverage   68.07%   63.43%   -4.64%     
==========================================
  Files           8        8              
  Lines         332      361      +29     
  Branches       59       67       +8     
==========================================
+ Hits          226      229       +3     
- Misses        101      127      +26     
  Partials        5        5
Impacted Files Coverage Δ
src/main.ts 98.16% <100%> (+0.01%) ⬆️
src/base.config.ts 26.59% <6.25%> (-8.26%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8a7856c...878a325. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants