Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding HTTPS serve #153

Merged
merged 3 commits into from
Aug 31, 2018
Merged

Adding HTTPS serve #153

merged 3 commits into from
Aug 31, 2018

Conversation

rorticus
Copy link
Contributor

@rorticus rorticus commented Aug 30, 2018

I once liked the HTTP service,
but lately it's making me nervous,
a few lines of code,
an HTTPS mode,
now safe and secure it preserves us.

If .cert/server.key and .cert/server.crt are detected, dojo build will now serve files via HTTPS.

Resolves #43

@codecov
Copy link

codecov bot commented Aug 30, 2018

Codecov Report

Merging #153 into master will increase coverage by 1.17%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #153      +/-   ##
==========================================
+ Coverage      56%   57.17%   +1.17%     
==========================================
  Files           8        8              
  Lines         475      488      +13     
  Branches      113      116       +3     
==========================================
+ Hits          266      279      +13     
  Misses        209      209
Impacted Files Coverage Δ
src/main.ts 93.75% <100%> (+0.62%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7e6b785...92dc460. Read the comment docs.

Copy link
Contributor

@mwistrand mwistrand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants