Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support built themes and other external css correctly #179

Merged
merged 1 commit into from
Oct 2, 2018

Conversation

agubler
Copy link
Member

@agubler agubler commented Oct 2, 2018

In order to support built themes and other external CSS we need to ensure we are not processing imports through postcss.

CSS imports always need to contain the extension and must use a tilde prefix when referencing from node_modules:

@import '~@dojo/theme/dojo/index.css'

@codecov
Copy link

codecov bot commented Oct 2, 2018

Codecov Report

Merging #179 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #179   +/-   ##
=======================================
  Coverage   54.72%   54.72%           
=======================================
  Files          10       10           
  Lines         550      550           
  Branches      129      129           
=======================================
  Hits          301      301           
  Misses        249      249
Impacted Files Coverage Δ
src/base.config.ts 26.08% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f8bc6d0...ca15c94. Read the comment docs.

@agubler agubler merged commit 007868d into dojo:master Oct 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants