Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update logger.ts to point to package.json for cli-build-app #182

Merged
merged 1 commit into from
Oct 11, 2018

Conversation

jamesvhays
Copy link
Contributor

Previously pointed to package.json of the project cli-build-app is installed in.

@jsf-clabot
Copy link

jsf-clabot commented Oct 10, 2018

CLA assistant check
All committers have signed the CLA.

@matt-gadd
Copy link
Contributor

Thanks for the contribution! Unfortunately due to some slight difference between running and testing, the package.json doesn't live in the same folder between them, which is why the build is failing. Do you think you could try replacing __dirname with https://github.com/sindresorhus/pkg-up?

@jamesvhays
Copy link
Contributor Author

@matt-gadd sure, I can check that out.

@matt-gadd
Copy link
Contributor

@jamesvhays awesome! thanks.

@codecov
Copy link

codecov bot commented Oct 11, 2018

Codecov Report

Merging #182 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #182   +/-   ##
=======================================
  Coverage   54.72%   54.72%           
=======================================
  Files          10       10           
  Lines         550      550           
  Branches      129      129           
=======================================
  Hits          301      301           
  Misses        249      249
Impacted Files Coverage Δ
src/logger.ts 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 378a996...d66c996. Read the comment docs.

@jamesvhays
Copy link
Contributor Author

@matt-gadd I ended up just passing the __dirname argument to the package that was originally in there. Should have done that the first time!

@matt-gadd
Copy link
Contributor

@jamesvhays ha perfect! finally we'll be able to know what version people are using when they post a screenshot with problems 😄. This will make it into the 4.0.0 release next week, thanks for the contribution ⭐️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants