-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update logger.ts to point to package.json for cli-build-app #182
Conversation
Thanks for the contribution! Unfortunately due to some slight difference between running and testing, the package.json doesn't live in the same folder between them, which is why the build is failing. Do you think you could try replacing |
@matt-gadd sure, I can check that out. |
@jamesvhays awesome! thanks. |
Codecov Report
@@ Coverage Diff @@
## master #182 +/- ##
=======================================
Coverage 54.72% 54.72%
=======================================
Files 10 10
Lines 550 550
Branches 129 129
=======================================
Hits 301 301
Misses 249 249
Continue to review full report at Codecov.
|
@matt-gadd I ended up just passing the __dirname argument to the package that was originally in there. Should have done that the first time! |
@jamesvhays ha perfect! finally we'll be able to know what version people are using when they post a screenshot with problems 😄. This will make it into the 4.0.0 release next week, thanks for the contribution ⭐️ |
Previously pointed to package.json of the project cli-build-app is installed in.