Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Bootstrap Plugin #220

Merged
merged 5 commits into from
Dec 11, 2018
Merged

Use Bootstrap Plugin #220

merged 5 commits into from
Dec 11, 2018

Conversation

agubler
Copy link
Member

@agubler agubler commented Dec 11, 2018

Type: feature

The following has been addressed in the PR:

  • There is a related issue
  • All code has been formatted with prettier
  • Unit or Functional tests are included in the PR

Description:

Use the BootstrapPlugin configured to conditionally load supported shims based on usage and client capabilities.

Related to dojo/framework#183

@codecov
Copy link

codecov bot commented Dec 11, 2018

Codecov Report

Merging #220 into master will decrease coverage by 0.2%.
The diff coverage is 20%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #220      +/-   ##
==========================================
- Coverage   53.93%   53.73%   -0.21%     
==========================================
  Files          10       10              
  Lines         597      603       +6     
  Branches      144      147       +3     
==========================================
+ Hits          322      324       +2     
- Misses        275      279       +4
Impacted Files Coverage Δ
src/base.config.ts 21.96% <14.28%> (-0.4%) ⬇️
src/dev.config.ts 21.15% <33.33%> (+1.15%) ⬆️
src/dist.config.ts 33.89% <33.33%> (+1.64%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3e02d04...b54af6d. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants