Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CSS source maps #225

Merged
merged 4 commits into from
Dec 17, 2018
Merged

Fix CSS source maps #225

merged 4 commits into from
Dec 17, 2018

Conversation

agubler
Copy link
Member

@agubler agubler commented Dec 14, 2018

Type: bug

The following has been addressed in the PR:

  • There is a related issue
  • All code has been formatted with prettier
  • Unit or Functional tests are included in the PR

Description:

Always use optimize-css-assets-webpack-plugin, not just in dev mode. Pass options to ensure that source-maps are preserved.

Resolves #218

@codecov
Copy link

codecov bot commented Dec 17, 2018

Codecov Report

Merging #225 into master will decrease coverage by 0.95%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #225      +/-   ##
==========================================
- Coverage   53.64%   52.68%   -0.96%     
==========================================
  Files          10       10              
  Lines         604      596       -8     
  Branches      147      144       -3     
==========================================
- Hits          324      314      -10     
- Misses        280      282       +2
Impacted Files Coverage Δ
src/dist.config.ts 32.2% <ø> (-1.13%) ⬇️
src/base.config.ts 22.85% <100%> (+0.89%) ⬆️
src/main.ts 90.58% <0%> (-1.6%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d8fc06d...1a8042a. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants