Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use manifest.json for logging #231

Merged
merged 6 commits into from
Jan 16, 2019
Merged

Conversation

agubler
Copy link
Member

@agubler agubler commented Jan 11, 2019

Type: feature

The following has been addressed in the PR:

  • There is a related issue
  • All code has been formatted with prettier
  • Unit or Functional tests are included in the PR

Description:

Favour the manifest.json over the webpack stats object for reporting asset information to the console.

@codecov
Copy link

codecov bot commented Jan 16, 2019

Codecov Report

Merging #231 into master will increase coverage by 0.47%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #231      +/-   ##
==========================================
+ Coverage    52.5%   52.97%   +0.47%     
==========================================
  Files          10       10              
  Lines         600      606       +6     
  Branches      146      148       +2     
==========================================
+ Hits          315      321       +6     
  Misses        285      285
Impacted Files Coverage Δ
src/logger.ts 100% <100%> (ø) ⬆️
src/dist.config.ts 32.2% <0%> (ø) ⬆️
src/dev.config.ts 21.15% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update add134e...2e25551. Read the comment docs.

@agubler agubler changed the title WIP: Use manifest.json for logging Use manifest.json for logging Jan 16, 2019
@agubler agubler merged commit 11c5639 into dojo:master Jan 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants