Fix custom element initialization #394
Conversation
|
@maier49 FYI, this seems to be failing CI. |
| child = document.createTextNode('bar'); | ||
| element!.appendChild(child); | ||
|
|
||
| waitFor( |
There was a problem hiding this comment.
curious, do you need to return this to ensure that the test waits for the promise to be resolved?
There was a problem hiding this comment.
Yes 🤦♂ . This is actually broken in IE. Looking into it
There was a problem hiding this comment.
@agubler Ok it was still the test that was broken I just didn't fix it properly. Should be good now (pending CI)
maier49
force-pushed
the
342-custom-element-fix-v6
branch
from
e028563 to
ccfa3f8
Compare
maier49
force-pushed
the
342-custom-element-fix-v6
branch
from
ccfa3f8 to
b5a20b6
Compare
|
@agubler A problem with the approach I was using is that if no children are appended it might never call the ready callback. I've updated it to use |
|
@agubler Testing against the v5 custom elements showcase everything worked properly out of the box. But there were was an issue with the setup being called too many times when I put the element scripts in the head. Have that fixed now, here's the showcase with the scripts in the head: |
Type: bug
The following has been addressed in the PR:
prettieras per the readme code style guidelinesDescription:
It's evidently not guaranteed that a custom element's children will be available when it is connected (see discussion here), but our
connectedCallbackwas setup as if it was. I've setup a mutation observer so that the element will wait till the document is loaded or an element after it in the HTML hierarchy is present to perform setup logic.Resolves #342