Add static references for Dijit constructor #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #11 +/- ##
==========================================
+ Coverage 94.64% 94.82% +0.18%
==========================================
Files 2 2
Lines 56 58 +2
Branches 12 12
==========================================
+ Hits 53 55 +2
Partials 3 3
Continue to review full report at Codecov.
|
agubler
approved these changes
Sep 27, 2017
kitsonk
force-pushed
the
bug-ie11-constructor
branch
from
1d3ae0d
to
789c80b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type: bug
The following has been addressed in the PR:
Description:
By holding static references on the class object, it appears to stop IE11 from doing mis-appropriate GC on arguments passed the mixin function. Gotta love browser inconsistency.
Resolves #10