Adding to cache as soon as require.cache is called instead of pending…

… it for later, issue #124
dojo · Apr 28, 2017 · dde74b9 · dde74b9
1 parent 1cb0fcf
commit dde74b9
Show file tree

Hide file tree

Showing 2 changed files with 59 additions and 23 deletions.
diff --git a/src/loader.ts b/src/loader.ts
@@ -399,20 +399,6 @@ declare const Packages: {} | undefined;
 		return <T> target;
 	}
 
-	function consumePendingCacheInsert(referenceModule?: DojoLoader.Module): void {
-		let item: any;
-
-		for (let key in pendingCacheInsert) {
-			item = pendingCacheInsert[key];
-
-			cache[
-				typeof item === 'string' ? toUrl(key, referenceModule) : getModuleInformation(key, referenceModule).mid
-			] = item;
-		}
-
-		pendingCacheInsert = {};
-	}
-
 	function noop(): void {};
 
 	let loadNodeModule: (moduleId: string, parent?: DojoLoader.Module) => any = noop;
@@ -844,9 +830,6 @@ declare const Packages: {} | undefined;
 		else if (module && !module.injected) {
 			let cached: DojoLoader.Factory;
 			const onLoadCallback = function (node?: HTMLScriptElement): void {
-				// DojoLoader.moduleDefinitionArguments is an array of [dependencies, factory]
-				consumePendingCacheInsert(module);
-
 				let moduleDefArgs: string[] = [];
 				let moduleDefFactory: DojoLoader.Factory | undefined = undefined;
 
@@ -867,7 +850,7 @@ declare const Packages: {} | undefined;
 
 			++waitingCount;
 			module.injected = true;
-			if ((cached = cache[module.mid])) {
+			if ((cached = cache[module.mid]) || (module.mid in pendingCacheInsert)) {
 				try {
 					cached();
 					onLoadCallback();
@@ -1118,9 +1101,16 @@ declare const Packages: {} | undefined;
 		toAbsMid: toAbsMid,
 		toUrl: toUrl,
 
-		cache: function (cache: DojoLoader.ObjectMap): void {
-			consumePendingCacheInsert();
-			pendingCacheInsert = cache;
+		cache: function (cacheModules: DojoLoader.ObjectMap): void {
+			let item: any;
+
+			for (let key in cacheModules) {
+				item = cacheModules[key];
+
+				cache[
+					typeof item === 'string' ? toUrl(key, undefined) : getModuleInformation(key, undefined).mid
+					] = item;
+			}
 		}
 	});
 

diff --git a/tests/unit/require.ts b/tests/unit/require.ts
@@ -709,7 +709,26 @@ registerSuite({
 		}
 	},
 
-	'cache injected module is properly undefined'(this: any) {
+	'circular dependencies are required'(this: any) {
+		let dfd = this.async(DEFAULT_TIMEOUT);
+
+		global.require.config({
+			packages: [
+				{
+					name: 'recursive',
+					location: './_build/tests/common/recursive'
+				}
+			]
+		});
+
+		global.require([
+			'recursive/a'
+		], dfd.callback(function (a: any) {
+			assert.equal(a, 'a');
+		}));
+	},
+
+	'require.cache creates modules with only the cache call'(this: any) {
 		let dfd = this.async(DEFAULT_TIMEOUT);
 
 		global.require.config({
@@ -729,7 +748,34 @@ registerSuite({
 			}
 		});
 
-		global.require.cache({}); /* TODO: Remove when #124 resolve */
+		assert.doesNotThrow(() => {
+			global.require([
+				'common/app'
+			], dfd.callback((app: any) => {
+				assert.strictEqual(app, 'mock', 'should return cache factory value');
+			}));
+		});
+	},
+
+	'cache injected module is properly undefined'(this: any) {
+		let dfd = this.async(DEFAULT_TIMEOUT);
+
+		global.require.config({
+			packages: [
+				{
+					name: 'common',
+					location: './_build/tests/common'
+				}
+			]
+		});
+
+		global.require.cache({
+			'common/app'() {
+				define([], () => {
+					return 'mock';
+				});
+			}
+		});
 
 		global.require([
 			'common/app'