Adding to cache as soon as require.cache is called instead of pending…

[rorticus]

… it for later, issue #124

Type: bug

The following has been addressed in the PR:

• There is a related issue
• All code matches the style guide
• Unit or Functional tests are included in the PR

Description:

It looks like maybe there was some logic to defer a require.cache operation until it was required for the first time, so it could get a reference module, but what's being done now doesn't really line up with that. It's now adding to the cache as soon as you call require.cache.

Resolves #124

[codecov]

Codecov Report

Merging #129 into master will decrease coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #129      +/-   ##
==========================================
- Coverage   85.63%   85.63%   -0.01%     
==========================================
  Files           1        1              
  Lines         550      543       -7     
  Branches      137      136       -1     
==========================================
- Hits          471      465       -6     
  Misses         32       32              
+ Partials       47       46       -1

Impacted Files	Coverage Δ
src/loader.ts	85.63% <100%> (-0.01%)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 020f647...0cc8292. Read the comment docs.

[kitsonk]

There are lines of uncovered code here that we should really address.

[rorticus]

@kitsonk Is that in relation to these cache changes, or just an overall observation? If its just an in-general thing, we should raise another issue for it and get them cleaned up 👍

[kitsonk]

@rorticus it is relation to this PR: Hits 471 464 -7 Because the codecov.io doesn't have the remapping configuration, I can't easily see which lines it is. But some code touched in this PR (more lines) is going in untested.