Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forward compatible updates for TS 2.4 #137

Merged
merged 1 commit into from
Jun 28, 2017
Merged

Conversation

kitsonk
Copy link
Member

@kitsonk kitsonk commented Jun 23, 2017

Type: bug

The following has been addressed in the PR:

  • There is a related issue
  • All code matches the style guide
  • Unit or Functional tests are included in the PR

Description:

This PR is a forward compatible change to address issues when migrating to TS2.4.

@kitsonk kitsonk requested review from agubler and rorticus June 23, 2017 09:55
@kitsonk
Copy link
Member Author

kitsonk commented Jun 23, 2017

Refs dojo/meta#189

@agubler
Copy link
Member

agubler commented Jun 23, 2017

Looks good, but there are test failures.

@kitsonk
Copy link
Member Author

kitsonk commented Jun 23, 2017

Yeah, master is failing with the same errors. Appears to be some sort of regression with Firefox when running in a CSP mode. I will open a separate issue.

@kitsonk
Copy link
Member Author

kitsonk commented Jun 23, 2017

Refs #138

@kitsonk kitsonk merged commit 905199f into dojo:master Jun 28, 2017
@dylans dylans added this to the 2017.06 milestone Jul 4, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants