-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clarity between Dojo 1.x and 2.x packages #174
Comments
Re:
|
I plan on changing all the repo descriptions for Dojo 1 - xx e.g. for
For dojo 2 repos, I plan on ensuring all the repo desciptions are in the form: 🚀 Dojo 2 - xx e.g. for 🚀 Dojo 2 - UI components |
Just to note that with the loaderless-intern work that Jason has been doing, https://github.com/theintern/intern/blob/loaderless-intern/package.json |
@dylans can you 👍 or 👎 the comment above about the repo descriptions before I go through and change pls? |
Yes, the challenge is all of the versions of Intern 2.x and 3.x that will break if the repo is just going. So we probably need to go back and publish a version of every Intern 2.x and 3.x with a dependency on whatever the new name is. Also as Kit pointed out, we may still need a repo call dojo2 to not break our current single gitter channel for Dojo 2. |
@dylan does it require the GitHub repo? |
And for the Gitter stuff, |
it can probably just require the npm tag, we'll need to verify with @jason0x43
Probably, but meta is such a fun self-troll over meta problems. |
Yup I can't see a reason why it would need the repo. As the dependency is actually |
I'm not sure what harm the repo is actually causing? It doesn't show up on an npm package search (grunt-dojo2 is actually the first result for dojo2) and it displays a big deprecated warning on the result returned from google. |
Because it makes it look like Dojo 2 is deprecated (for people that are tl;dr) |
Agreed. In that case my previous comment still stands that we don't need the repo for intern. |
I assume any incremental bug fix releases to old versions of Intern can continue to rely on the already published version. If that's the case, then yes, I agree, though it should still live somewhere in case someone needs it for something later (hopefully never). |
We could just rename the repo as it has no bearing on the actual package it publishes to npm 😄 Maybe |
OK - so I think gitter should just move to our org I have been through all repos and done the following:
|
Ok, because npm just pulls in data from the readme and package.json, we may want to make changes there as well for the repos? I noticed the dojo/loader readme also uses dojo2 rather than Dojo 2. Also after 2.0 is released, we should probably change to 2+. Moving gitter to the org seems fine to me. |
Refs #166 |
That other actions are their for this. It is unclear. If there are other actions, maybe we should close this and break them out as separate issues? |
No feedback for 3 months, closing. Any actions should be open as new issues. |
The text was updated successfully, but these errors were encountered: