Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarity between Dojo 1.x and 2.x packages #174

Closed
2 of 4 tasks
dylans opened this issue Apr 3, 2017 · 19 comments
Closed
2 of 4 tasks

Clarity between Dojo 1.x and 2.x packages #174

dylans opened this issue Apr 3, 2017 · 19 comments
Assignees
Labels
Milestone

Comments

@dylans
Copy link
Member

dylans commented Apr 3, 2017

  • Review all dojo packages to verify that they state clearly if they are part of Dojo 1.x or 2.0+
  • Update org description to be clear about 2.0+ vs. 1.x
  • Update URL in org to dojo.io (verify we're ready for that)
  • Do something about dojo/dojo2 package as that is completely confusing now (would require updates to Intern and perhaps others)
@dylans dylans added this to the 2017.04 milestone Apr 3, 2017
@rishson rishson added the beta2 label Apr 3, 2017
@rishson
Copy link
Contributor

rishson commented Apr 4, 2017

Re: dojo/dojo2:

  • Update README, repo tags and repo description
  • make sure that intern can move off this package
  • unpublish
  • rename repo
  • change all references to gitter, e.g. README on dojo/meta to point to dojo org room rather than the dojo2 repo room.

@rishson
Copy link
Contributor

rishson commented Apr 4, 2017

I plan on changing all the repo descriptions for dojo1 repos to:

Dojo 1 - xx

e.g.

for dojo/dojo:

Dojo 1 - the Dojo toolkit core library.

For dojo 2 repos, I plan on ensuring all the repo desciptions are in the form:

🚀 Dojo 2 - xx

e.g. for dojo/widgets

🚀 Dojo 2 - UI components

@agubler
Copy link
Member

agubler commented Apr 4, 2017

Just to note that with the loaderless-intern work that Jason has been doing, intern has already moved away from the dojo package published from dojo/dojo2.

https://github.com/theintern/intern/blob/loaderless-intern/package.json

@rishson
Copy link
Contributor

rishson commented Apr 4, 2017

@dylans can you 👍 or 👎 the comment above about the repo descriptions before I go through and change pls?

@dylans
Copy link
Member Author

dylans commented Apr 4, 2017

Just to note that with the loaderless-intern work that Jason has been doing, intern has already moved away from the dojo package published from dojo/dojo2.

Yes, the challenge is all of the versions of Intern 2.x and 3.x that will break if the repo is just going. So we probably need to go back and publish a version of every Intern 2.x and 3.x with a dependency on whatever the new name is.

Also as Kit pointed out, we may still need a repo call dojo2 to not break our current single gitter channel for Dojo 2.

@agubler
Copy link
Member

agubler commented Apr 4, 2017

@dylan does it require the GitHub repo?

@agubler
Copy link
Member

agubler commented Apr 4, 2017

And for the Gitter stuff, meta should probably be dojo2....

@dylans
Copy link
Member Author

dylans commented Apr 4, 2017

@dylan does it require the GitHub repo?

it can probably just require the npm tag, we'll need to verify with @jason0x43

And for the Gitter stuff, meta should probably be dojo2

Probably, but meta is such a fun self-troll over meta problems.

@agubler
Copy link
Member

agubler commented Apr 4, 2017

Yup I can't see a reason why it would need the repo. As the dependency is actually dojo but published from dojo/dojo2 repo on the 2.0.0-Alpha.* versions

@agubler
Copy link
Member

agubler commented Apr 4, 2017

I'm not sure what harm the repo is actually causing? It doesn't show up on an npm package search (grunt-dojo2 is actually the first result for dojo2) and it displays a big deprecated warning on the result returned from google.

@dylans
Copy link
Member Author

dylans commented Apr 4, 2017

Because it makes it look like Dojo 2 is deprecated (for people that are tl;dr)

@agubler
Copy link
Member

agubler commented Apr 4, 2017

Agreed. In that case my previous comment still stands that we don't need the repo for intern.

@dylans
Copy link
Member Author

dylans commented Apr 4, 2017

Agreed. In that case my previous comment still stands that we don't need the repo for intern.

I assume any incremental bug fix releases to old versions of Intern can continue to rely on the already published version. If that's the case, then yes, I agree, though it should still live somewhere in case someone needs it for something later (hopefully never).

@agubler
Copy link
Member

agubler commented Apr 4, 2017

We could just rename the repo as it has no bearing on the actual package it publishes to npm 😄 Maybe dojo-intern

@rishson
Copy link
Contributor

rishson commented Apr 5, 2017

OK - so I think gitter should just move to our org dojo (you can have org rooms as well as repo rooms).
I think we should rename dojo/dojo2 to dojo/dojo-intern and mark as '(internal use)'.

I have been through all repos and done the following:

  • All descriptions start with 'Dojo 1 -' or '🚀 Dojo 2 -' (internal use repos don't get the nice rocket tho)
  • All deprecated repos now have 'deprecated' tag
  • All 'proposed' repos now have 'proposed' tag
  • All 'internal use' repose now have this suffix in their description.

@dylans
Copy link
Member Author

dylans commented Apr 5, 2017

Ok, because npm just pulls in data from the readme and package.json, we may want to make changes there as well for the repos? I noticed the dojo/loader readme also uses dojo2 rather than Dojo 2. Also after 2.0 is released, we should probably change to 2+.

Moving gitter to the org seems fine to me.

@rishson
Copy link
Contributor

rishson commented Apr 10, 2017

Refs #166

@dylans dylans modified the milestones: 2017.04, 2017.05 Apr 29, 2017
@eheasley eheasley added beta3 and removed beta2 labels Jun 6, 2017
@eheasley eheasley modified the milestones: 2017.05, 2017.06 Jun 6, 2017
@eheasley eheasley removed this from the 2017.05 milestone Jun 6, 2017
@dylans dylans modified the milestones: 2017.06, 2017.07 Jul 4, 2017
@kitsonk
Copy link
Member

kitsonk commented Jul 27, 2017

That other actions are their for this. It is unclear. If there are other actions, maybe we should close this and break them out as separate issues?

@dylans dylans modified the milestones: 2017.07, 2017.08 Jul 29, 2017
@kitsonk kitsonk modified the milestones: 2017.08, 2017.09 Sep 4, 2017
@kitsonk
Copy link
Member

kitsonk commented Oct 9, 2017

No feedback for 3 months, closing. Any actions should be open as new issues.

@kitsonk kitsonk closed this as completed Oct 9, 2017
@dylans dylans modified the milestones: 2017.09, 2017.10 Oct 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants