Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Dojo url in package.json #166

Closed
dylans opened this issue Mar 28, 2017 · 10 comments
Closed

Update Dojo url in package.json #166

dylans opened this issue Mar 28, 2017 · 10 comments
Assignees
Milestone

Comments

@dylans
Copy link
Member

dylans commented Mar 28, 2017

Once dojo.io is live, update url in various package.json repos to dojo.io so that it links to that on npm for future releases.

@dylans dylans added this to the 2017.04 milestone Mar 28, 2017
@rishson rishson added the beta2 label Apr 11, 2017
@rishson
Copy link
Contributor

rishson commented Apr 11, 2017

@rishson
Copy link
Contributor

rishson commented Apr 12, 2017

@agubler if we wanted to make this less painful, then would we alter grunt-dojo2 's package to check the package.json 's homepage and autocorrect to dojo.io or would it be better to do this, or some other solution?

rishson added a commit to dojo/dojo-package-template that referenced this issue Apr 12, 2017
rishson added a commit to dojo/dojo-package-template that referenced this issue Apr 13, 2017
@agubler
Copy link
Member

agubler commented Apr 18, 2017

@rishson It certainly is possible to enhance the release task to correct package.json meta data on release.

We could also potentially create a task that can auto update package.json meta independently of the release.

@rishson
Copy link
Contributor

rishson commented Apr 18, 2017

@agubler yup and I have a PR ready to go for enhancing the release task. Would you prefer a generic 'alter metadata' task, e.g. here, or a hardcoded update url check to the release task?

@dylans dylans modified the milestones: 2017.04, 2017.05 Apr 29, 2017
@rishson
Copy link
Contributor

rishson commented May 22, 2017

Most repos will now be updated by #183

@eheasley eheasley added beta3 and removed beta2 labels Jun 6, 2017
@eheasley eheasley modified the milestones: 2017.05, 2017.06 Jun 6, 2017
@dylans dylans modified the milestones: 2017.06, 2017.07 Jul 4, 2017
@kitsonk
Copy link
Member

kitsonk commented Jul 27, 2017

Let's try to action this and close it out. @eheasley if Dylan doesn't have the time, we should assign it to others.

@dylans dylans removed this from the 2017.07 milestone Jul 29, 2017
@kitsonk kitsonk modified the milestones: 2017.09, 2017.08 Sep 4, 2017
@kitsonk kitsonk modified the milestones: 2017.09, 2017.10 Oct 9, 2017
@kitsonk
Copy link
Member

kitsonk commented Oct 9, 2017

Again, please action this.

@edhager
Copy link

edhager commented Oct 17, 2017

Skipping dojo/examples because it does not have a package.json file.

@edhager
Copy link

edhager commented Oct 17, 2017

PRs have been created for the unchecked (for now) repos above.

@kitsonk kitsonk modified the milestones: 2017.10, beta.4 Oct 30, 2017
@edhager
Copy link

edhager commented Oct 31, 2017

All PRs have been landed.

@edhager edhager closed this as completed Oct 31, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants