Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: submodule #272

Merged
merged 14 commits into from
Sep 25, 2024
Merged

fix: submodule #272

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
55ed064
fix: submodule
ponderingdemocritus Sep 24, 2024
52743fa
fix: ci
ponderingdemocritus Sep 24, 2024
b85f225
feat: submodule
ponderingdemocritus Sep 24, 2024
5314a67
fix: tests
ponderingdemocritus Sep 24, 2024
5cec278
fix: tests
ponderingdemocritus Sep 24, 2024
09eaeac
fix: release yaml
ponderingdemocritus Sep 24, 2024
49afac9
fix: bump lerna
ponderingdemocritus Sep 24, 2024
922fb99
fix: package versions
ponderingdemocritus Sep 24, 2024
e4368f5
fix: lockfile
ponderingdemocritus Sep 24, 2024
16dbaaa
chore: version bumps
ponderingdemocritus Sep 25, 2024
e3000bc
fix: prettier
ponderingdemocritus Sep 25, 2024
b7fe164
fix: remove examples from CI
ponderingdemocritus Sep 25, 2024
46e6fc3
feat: revert ci
ponderingdemocritus Sep 25, 2024
41a0bf0
fix: ....
ponderingdemocritus Sep 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/ci.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ jobs:
- run: curl -L https://install.dojoengine.org | bash
- run: /home/runner/.config/.dojo/bin/dojoup -v v1.0.0-alpha.6
- run: |
cd examples/dojo/dojo-starter
cd worlds/dojo-starter
/home/runner/.config/.dojo/bin/sozo build
/home/runner/.config/.dojo/bin/sozo test

Expand Down
2 changes: 1 addition & 1 deletion .gitmodules
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
[submodule "dojo-starter"]
path = examples/dojo-starter
path = worlds/dojo-starter
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codebase verification

Action Required: Update remaining references to the old submodule path.

The following files still reference examples/dojo-starter and should be updated to worlds/dojo-starter:

  • readme.md
    • Line with cd examples/dojo-starter
    • Another line with cd examples/dojo-starter
  • examples/example-nodejs-bot/tsconfig.json
    • "exclude": ["examples/dojo-starter/target/dev/manifest.json"]

Please ensure these paths are updated to reflect the new submodule location to maintain consistency across the project.

Analysis chain

LGTM! Verify consistency across the project.

The change to the submodule path from examples/dojo-starter to worlds/dojo-starter looks good. This appears to be a directory restructuring, which aligns with the PR title "fix: submodule".

To ensure consistency across the project, please run the following script to check for any references to the old path:

This script will help identify any potential inconsistencies or references that might need updating due to this path change.

LGTM! Verify no residual references to the old submodule path.

To ensure that there are no remaining references to examples/dojo-starter outside of .gitmodules, please run the following script:

Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Check for references to the old submodule path

# Search for references to the old path
echo "Searching for references to 'examples/dojo-starter':"
rg --type-not gitmodules "examples/dojo-starter"

# Check if the new directory structure exists
echo "Checking if the new directory structure exists:"
if [ -d "worlds/dojo-starter" ]; then
    echo "Directory 'worlds/dojo-starter' exists."
else
    echo "Warning: Directory 'worlds/dojo-starter' does not exist."
fi

# Verify submodule status
echo "Verifying submodule status:"
git submodule status

Length of output: 587

Script:

#!/bin/bash
# Description: Check for references to the old submodule path excluding .gitmodules

echo "Searching for references to 'examples/dojo-starter' excluding .gitmodules:"
rg "examples/dojo-starter" --glob '!**/.gitmodules'

Length of output: 394

url = https://github.com/dojoengine/dojo-starter
Loading