Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: constants #305

Merged
merged 4 commits into from
Oct 21, 2024
Merged

fix: constants #305

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
6d347cd
fix: constants
ponderingdemocritus Oct 21, 2024
3333a2c
fix: dojo version
ponderingdemocritus Oct 21, 2024
2dbe619
fix: const type
ponderingdemocritus Oct 21, 2024
640ec75
fix: linting
ponderingdemocritus Oct 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions packages/core/src/constants/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,10 +2,10 @@ export const LOCAL_KATANA = "http://localhost:5050";
export const LOCAL_RELAY = "";
export const LOCAL_TORII = "http://0.0.0.0:8080";
export const KATANA_PREFUNDED_ADDRESS =
"0xb3ff441a68610b30fd5e2abbf3a1548eb6ba6f3559f2862bf2dc757e5828ca";
"0x127fd5f1fe78a71f8bcd1fec63e3fe2f0486b6ecd5c86a0466c3a21fa5cfcec";
export const KATANA_PREFUNDED_PRIVATE_KEY =
"0x2bbf4f9fd0bbb2e60b0316c1fe0b76cf7a4d0198bd493ced9b8df2a3a24d68a";
"0x127fd5f1fe78a71f8bcd1fec63e3fe2f0486b6ecd5c86a0466c3a21fa5cfcec";
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue

Critical: KATANA_PREFUNDED_PRIVATE_KEY matches KATANA_PREFUNDED_ADDRESS

The new value for KATANA_PREFUNDED_PRIVATE_KEY is identical to the new KATANA_PREFUNDED_ADDRESS. This is highly unusual and potentially a security risk. Private keys and addresses should be distinct in cryptographic systems. Please urgently clarify:

  1. Is this intentional? If so, what's the rationale?
  2. If not, what should the correct private key be?
  3. Has this been exposed in any public environments?

If this is unintentional, please update the private key to a distinct, secure value immediately.

export const KATANA_CLASS_HASH =
"0x05400e90f7e0ae78bd02c77cd75527280470e2fe19c54970dd79dc37a9d3645c";
"0x07dc7899aa655b0aae51eadff6d801a58e97dd99cf4666ee59e704249e51adf2";
export const KATANA_ETH_CONTRACT_ADDRESS =
"0x49d36570d4e46f48e99674bd3fcc84644ddd6b96f7c741b1562b82f9e004dc7";
2 changes: 1 addition & 1 deletion worlds/dojo-starter
Open in desktop
Submodule dojo-starter updated 7 files
+1 −1 .github/workflows/test.yaml
+1 −1 README.md
+1 −1 Scarb.lock
+1 −1 Scarb.toml
+2 −2 dojo_dev.toml
+1 −1 manifests/dev/deployment/manifest.json
+1 −1 manifests/dev/deployment/manifest.toml
Loading