New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix model name generate logic in generate components script #94

Closed

satyambnsal wants to merge 1 commit into dojoengine:main from satyambnsal:main

satyambnsal commented Dec 21, 2023 •

edited

Loading

Closes #
#93

Introduced changes

generateComponents script generates incorrect model name if there is a two character word in model name

for example, for model file `player_at_position`, it generates `PlayerATPosition`, it should be `PlayerAtPosition`

Checklist

Linked relevant issue
Updated relevant documentation
Added relevant tests
Add a dedicated CI job for new examples
Performed self-review of the code


          Fix model name generate logic in generate components script

6ae740a

Contributor

ponderingdemocritus commented Dec 23, 2023

fixed in #97 with more edge cases

ponderingdemocritus closed this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet