Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dokku_image: Detect unchanged docker images #157

Merged
merged 1 commit into from
Feb 4, 2023

Conversation

blockloop
Copy link
Contributor

I believe this fixes #156
Happy to discuss

I believe this fixes dokku#156 
Happy to discuss
@blockloop
Copy link
Contributor Author

Temporary work around

- name: create app
  failed_when: "'error' in image_pull.meta and 'No changes detected, skipping git commit' not in image_pull.meta.error"
  register: image_pull
  dokku_image:
    app: &app nginx
    image: docker.io/nginx

@ltalirz ltalirz self-requested a review February 4, 2023 18:57
Copy link
Member

@ltalirz ltalirz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, thanks a lot for the fix!

@ltalirz ltalirz merged commit b376657 into dokku:master Feb 4, 2023
@blockloop blockloop deleted the patch-1 branch February 4, 2023 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

dokku_image: fails when the image is already up to date
2 participants