Blr and block map fixes #11840
Merged
Blr and block map fixes #11840
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JosJuice
previously approved these changes
May 23, 2023
|
Sorry, my press of the approve button was a little too hasty there. Instead of calling InitBLROptimization in RefreshConfig, could you call it in Jit64::Init and JitArm64::Init, where the code was moved from in b6256a5? I don't believe running InitBLROptimization in the middle of emulation will work as intended, so we shouldn't run it whenever the config is refreshed. |
|
What happens if the BLR optimization is valid on boot but then later the user changes some setting that makes it invalid? |
|
Then the BLR optimization continues to be applied for the time being. Fastmem works the same way. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BLR optimization was completely disabled for both x86 and arm64.
Block map fallback is my bad, sorry.