Remove temporary workaround for loopback bug in GMS (#6283)

Related Prereq: dolthub/go-mysql-server#1856
dolthub · Jul 6, 2023 · 65f2163 · 65f2163
1 parent 159e138
commit 65f2163
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 13 deletions.
diff --git a/go/cmd/dolt/commands/sqlserver/server.go b/go/cmd/dolt/commands/sqlserver/server.go
@@ -21,7 +21,6 @@ import (
 	"fmt"
 	"net"
 	"net/http"
-	"os"
 	"runtime"
 	"strconv"
 	"time"
@@ -224,11 +223,7 @@ func Serve(
 	lck := env.NewDBLock(serverConfig.Port())
 	sqlserver.SetRunningServer(mySQLServer, &lck)
 
-	localConnectionHost := "localhost"
-	if isDoltTestEnvSet() {
-		localConnectionHost = "%"
-	}
-	sqlEngine.GetUnderlyingEngine().Analyzer.Catalog.MySQLDb.AddSuperUser(LocalConnectionUser, localConnectionHost, lck.Secret)
+	sqlEngine.GetUnderlyingEngine().Analyzer.Catalog.MySQLDb.AddSuperUser(LocalConnectionUser, "localhost", lck.Secret)
 
 	var metSrv *http.Server
 	if serverConfig.MetricsHost() != "" && serverConfig.MetricsPort() > 0 {
@@ -519,8 +514,3 @@ func checkForUnixSocket(config ServerConfig) (string, bool, error) {
 
 	return "", false, nil
 }
-
-// isDoltTestEnvSet Temporary function to enable __dolt_local_user__ to be used until https://github.com/dolthub/dolt/issues/6239 is resolved
-func isDoltTestEnvSet() bool {
-	return os.Getenv("DOLT_ENABLE_LOCAL_USER_FOR_ALL_HOSTS") != ""
-}
diff --git a/integration-tests/bats/helper/common.bash b/integration-tests/bats/helper/common.bash
@@ -70,8 +70,6 @@ setup_no_dolt_init() {
     # during the cli -> sql migration.
     export DOLT_CLI_PASSWORD=""
     export DOLT_SILENCE_USER_REQ_FOR_TESTING="Y"
-    # Temporary Flag: https://github.com/dolthub/dolt/issues/6239
-    export DOLT_ENABLE_LOCAL_USER_FOR_ALL_HOSTS="Y"
 }
 
 assert_feature_version() {