Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support server side cursors #3029

Closed
VinaiRachakonda opened this issue Mar 17, 2022 · 2 comments
Closed

Support server side cursors #3029

VinaiRachakonda opened this issue Mar 17, 2022 · 2 comments
Labels
enhancement New feature or request

Comments

@VinaiRachakonda
Copy link
Contributor

Recently the MySQL FDW added the use of the mysql_stmt_store_result function. This requires server side cursors.

Until then we will support MySQL FDW up till REL-2_7_0
@VinaiRachakonda VinaiRachakonda changed the title Support server side cursors [MYSQL_FDW] Support server side cursors Mar 17, 2022
@fulghum fulghum added the enhancement New feature or request label Mar 17, 2022
@VinaiRachakonda VinaiRachakonda mentioned this issue Mar 17, 2022
Merged
@timsehn timsehn changed the title [MYSQL_FDW] Support server side cursors Support server side cursors Aug 30, 2022
@timsehn
Copy link
Contributor

timsehn commented Mar 3, 2023

This may be related to: #5441

@jycor jycor mentioned this issue Mar 23, 2023
Merged
@jycor
Copy link
Contributor

jycor commented Apr 11, 2023

The dolt server now partially implements server side cursors.

Some caveats:

  • We only allow one server side cursor to be open at a time.
  • The results are not stored in a temporary table like in MySQL, but rather we have a goroutine that blocks spooling the results from COM_STMT_EXECUTE, and waits for COM_STMT_FETCH.

Regardless it seems like dolt works well enough with MySQL FDW 2.9.0

@jycor jycor closed this as completed Apr 11, 2023
@jycor jycor mentioned this issue Apr 11, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@fulghum @timsehn @VinaiRachakonda @jycor