Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unblock the failing MySQL FDW integration test #3030

Merged
merged 2 commits into from
Mar 18, 2022
Merged

Unblock the failing MySQL FDW integration test #3030

merged 2 commits into from
Mar 18, 2022

Conversation

VinaiRachakonda
Copy link
Contributor

@VinaiRachakonda VinaiRachakonda commented Mar 17, 2022 •
edited
Loading

This pr:

  1. Switches to an older version of MySQL FDW due to Support server side cursors #3029
  2. Adds a comment in the c api to test an additional function
  3. Adds logic in the mysql bats client tests that shuts the down the postgres server in the teardown. Will be useful in case new versions of the wrapper cause another breakage.

coffeegoddd
coffeegoddd approved these changes Mar 18, 2022
View reviewed changes
Copy link
Contributor

@coffeegoddd coffeegoddd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@VinaiRachakonda VinaiRachakonda merged commit 774c731 into main Mar 18, 2022
@Hydrocharged Hydrocharged deleted the vinai/unblock-mysql-fdw branch April 10, 2022 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coffeegoddd coffeegoddd coffeegoddd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@VinaiRachakonda @coffeegoddd