Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow backticks in index names #3779

Merged
merged 4 commits into from
Jul 8, 2022
Merged

Allow backticks in index names #3779

merged 4 commits into from
Jul 8, 2022

Conversation

fulghum
Copy link
Contributor

@fulghum fulghum commented Jul 7, 2022 •
edited
Loading

Fixes: #3776

Related to: dolthub/go-mysql-server#1109

@fulghum fulghum mentioned this pull request Jul 8, 2022
Merged
@fulghum fulghum requested a review from zachmu July 8, 2022 18:27
zachmu
zachmu approved these changes Jul 8, 2022
View reviewed changes
Copy link
Member

@zachmu zachmu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG but it seems like we should probably be much less strict about checking identifier names. If it parses, we should accept it.

go/libraries/doltcore/doltdb/table.go Show resolved Hide resolved
@fulghum fulghum mentioned this pull request Jul 8, 2022
Closed
@fulghum fulghum merged commit 6c78330 into main Jul 8, 2022
@fulghum fulghum deleted the fulghum/issue-3776 branch July 8, 2022 23:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zachmu zachmu zachmu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support backticks in index names
2 participants
@fulghum @zachmu