Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring Dolt's use of ExternalStoredProcedureDatabase to ExternalStoredProcedureProvider #4021

Merged
merged 9 commits into from
Aug 11, 2022

Conversation

fulghum
Copy link
Contributor

@fulghum fulghum commented Aug 5, 2022

Fixes: #3934

Depends on: dolthub/go-mysql-server#1156

@fulghum fulghum changed the title Configuring dolt_clone to be available when no database is selected Updating Dolt from ExternalStoredProcedureDatabase to ExternalStoredProcedureProvider refactoring Aug 9, 2022
@fulghum fulghum changed the title Updating Dolt from ExternalStoredProcedureDatabase to ExternalStoredProcedureProvider refactoring Refactoring Dolt's use of ExternalStoredProcedureDatabase to ExternalStoredProcedureProvider Aug 10, 2022
@fulghum fulghum marked this pull request as ready for review August 10, 2022 18:29
Copy link
Member

@zachmu zachmu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@fulghum fulghum merged commit 2a14823 into main Aug 11, 2022
@fulghum fulghum deleted the fulghum/dolt_clone branch August 11, 2022 00:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

call dolt_clone() does not work if you have not used a database
2 participants