adding missing test cases for prepared tests #4163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o james/prepareds
max-hoffman
approved these changes
Aug 24, 2022
| @@ -822,29 +824,6 @@ var HistorySystemTableScriptTests = []queries.ScriptTest{ | |||
| {3, 4}, | |||
| }, | |||
| }, | |||
| { | |||
There was a problem hiding this comment.
it might be easier to leave these here with SkipPrepared=true, but still append to a new list of tests titled BrokenHistorySystemTableScriptTests .
There was a problem hiding this comment.
in which case you don't need the comment above
| @@ -1073,6 +1113,35 @@ func TestHistorySystemTable(t *testing.T) { | |||
| enginetest.TestScript(t, harness, test) | |||
| }) | |||
| } | |||
| for _, test := range BrokenHistorySystemTableScriptTests { | |||
| harness.engine = nil | |||
There was a problem hiding this comment.
you verified that the tests that include this cannot reuse the engine?
| @@ -66,21 +66,43 @@ func TestQueries(t *testing.T) { | |||
| func TestSingleQuery(t *testing.T) { | |||
| t.Skip() | |||
|
|
|||
| harness := newDoltHarness(t) | |||
There was a problem hiding this comment.
in general it is courteous to limit unnecessary changes that make PRs more difficult to read
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Companion PR:
Adds skipped tests for Queries that don't yet work Prepared